Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone namechange in America/North_Dakota #133

Closed
wants to merge 1 commit into from
Closed

Fix timezone namechange in America/North_Dakota #133

wants to merge 1 commit into from

Conversation

TimZaman
Copy link

@TimZaman TimZaman commented Aug 10, 2022

Confirmed working with overpass API. Without this change, a
No data for the following query would be thrown.

TLDR
Looks like a copy-paste error introduced here: a2014a9

Issue

getting data for America-North_Dakota-Beulah-tz; Downloading progress: 11.5% done - 1.2 hours left
downloading from overpass
waiting 8 seconds
query [out:json][timeout:60];(relation["timezone"="America-North_Dakota-Beulah-tz"];);out body;>;out meta qt;
Success, decreasing overpass request gap
No data for the following query:
[out:json][timeout:60];(relation["timezone"="America-North_Dakota-Beulah-tz"];);out body;>;out meta qt;
To read more about this error, please visit https://git.io/vxKQL
done
error! Error: No data found for from overpass query
    at asynclib.auto.validateOverpassResult (/Users/tzaman/dev/timezone-boundary-builder/index.js:338:19)
    at runTask (/Users/tzaman/dev/timezone-boundary-builder/node_modules/async/dist/async.js:1150:17)
    at /Users/tzaman/dev/timezone-boundary-builder/node_modules/async/dist/async.js:1088:35
    at processQueue (/Users/tzaman/dev/timezone-boundary-builder/node_modules/async/dist/async.js:1098:17)
    at taskComplete (/Users/tzaman/dev/timezone-boundary-builder/node_modules/async/dist/async.js:1115:13)
    at /Users/tzaman/dev/timezone-boundary-builder/node_modules/async/dist/async.js:1143:21
    at /Users/tzaman/dev/timezone-boundary-builder/node_modules/async/dist/async.js:324:20
    at overpassResponseHandler (/Users/tzaman/dev/timezone-boundary-builder/index.js:310:13)
    at overpass.flatProperties (/Users/tzaman/dev/timezone-boundary-builder/index.js:320:30)
    at Stream.toGeoJSON (/Users/tzaman/dev/timezone-boundary-builder/node_modules/query-overpass/index.js:18:9)

The statement `` is confirmed not returning data through overpass turbo, but [out:json][timeout:60];(relation["timezone"="America/North_Dakota/New_Salem"];);out body;>;out meta qt; is; link for proof: https://overpass-turbo.eu/s/1kTq

Confirmed working with overpass API. Without this change, a
`No data for the following query` would be thrown.
evansiroky added a commit that referenced this pull request Aug 24, 2022
@evansiroky
Copy link
Owner

Thanks for this! I went ahead and fixed this problem and some others in cabd7d0.

@evansiroky evansiroky closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants